thasmin / Podax

Podcast client for Android
Other
165 stars 34 forks source link

Downloads not alway finishes (and I am not sure how to restart downloader) #52

Closed mcepl closed 11 years ago

mcepl commented 12 years ago

Quite often downloads of podcasts gets to 100% (plus a bit more, probably a rounding error?) and then it stops there. It doesn't finish and the download doesn't go away from the downloader list.

In the old UI it helped to restart downloader couple of times, but I am not sure how to do it now (is it the two-arrows icon in the top bar? it doesn't seem to do anything now)

Obligatory log http://mcepl.fedorapeople.org/tmp/alogcat/alogcat.2012-05-19-22-32-26+0200.txt

thasmin commented 12 years ago

Can you get this to happen reliably? It only happens to me when I'm not testing.

The refresh icon on the actionbar is restart. I'm hoping to be able to take out the restart soon and just get it working.

mcepl commented 12 years ago

Not reliably, unfortunately. Very very often (33%?). Please, keep that restarting button there until this is really reliably 100% certainly resolved ... it is my only hope too often.

thasmin commented 12 years ago

I made some changes in 50f837e. I don't have confidence that the problems were fixed, but I thought I'd let you know in case you wanted to try it out.

thasmin commented 12 years ago

The problem is that multiple threads are downloading the file at once. I rewrote the downloader so it watches the queue instead of being trigger manually. I'm not sure if this way is better and may revert this change and just fix the threading.

mcepl commented 12 years ago

Synchronization on Queue? But, yes I'll try it.

thasmin commented 12 years ago

Can you give b6a3bdf a try? This should fix the problem but it may go too far in that if it has trouble downloading, it may be tough to restart. If you have problems, you can either kill the app and then restart the downloader or checkout 6e3941d and reinstall.

mcepl commented 12 years ago

Log is http://mcepl.fedorapeople.org/tmp/alogcat.2012-06-01-18-12-36+0200.txt ... I saw couple of stuck downloads (they just sit there and even restarting downloader doesn't make a difference), but I am not sure whether there is anything interesting in logs.

thasmin commented 12 years ago

That log had nothing about downloading, if there's a problem then it probably happened a while before you noticed.

I made some more changed in 9d05b59. I'm not hopeful that this fixed the problem, but if you have a chance, could you give it a try?

mcepl commented 12 years ago

9d05b59 works really poorly for me ... on every attempt to synchronize feeds I get crash. http://mcepl.fedorapeople.org/tmp/alogcat/alogcat.2012-06-05-00-02-57+0200.txt

thasmin commented 12 years ago

Weird that didn't happen to me. Fixed in 7e0f27b.

mcepl commented 12 years ago

Still some podcasts (Tech News Today is a good example, because it is supposed to be updated daily) are not refreshed. I am still on #511, although #514 is on the website (http://twit.tv/tnt).

Also updates from gpodder, don't happen (having Podax @ 7610dc1 and thasmin/gpodder_provider@941d3ff). I have added a podcasts on the website, but nothing has shown in Podax.

untitaker commented 12 years ago

Just an idea, how about checking the wifi status and then automatically restarting the downloader if we have an internet connection again?

thasmin commented 12 years ago

Sounds like a good idea.

mcepl commented 11 years ago

@thasmin couldn't this wifi dependency be created as a separate issue and this ticket closed? Although it may be #122 in disguise.

thasmin commented 11 years ago

There's a download button on the queue screen and a refresh button on the subscriptions screen, so I'm closing the issue.