search

thatcher / env-js

A pure-JavaScript browser environment.
http://www.envjs.com/
464 stars 75 forks source link

window.location = '#something' #16

Open yeungda opened 14 years ago

yeungda commented 14 years ago

in browsers, setting window.location to '#something' does not cause a page reload. It does in env-js though. i would like to use env.js with a single page web app and this behaviour is preventing the app from working properly when clicking links like .

i would like to write a patch that allows clicking of links to hashes. would you be interested in accepting such a change? From what I understand so far, it means changes to a.js to include the hash in the href getter, and changes to location.assign to identify when the change is a hash change only. i will include tests.

eeroan commented 13 years ago

I came up with exactly same problem. A work around is to set document.location.hash, but it becomes nasty when every third party library needs to be updated because of that.

So please, tell me when you have implemented the patch :)