search

thatcher / openseadragon

This project has moved to its new github organization at github.com/openseadragon, please join us!
http://openseadragon,github.com/
37 stars 14 forks source link

JSHint tidying #10

Closed acdha closed 11 years ago

acdha commented 12 years ago

I've been working my way through with JSHint (http://www.jshint.com/) cleaning up warnings. Most interesting is acdha@c54012addb9edc9a77e4e024f65a194e63818910 which actually causes a compile error if you attempt to use Closure Compiler.

Next up would be cleaning up variable declaration and some old usage of arguments in a way which, AFAICT, doesn't make sense for any browser in common use.

iangilman commented 11 years ago

This is awesome! Unfortunately it doesn't emerge cleanly anymore… Would you be up for updating it?

Also, if possible, let's do the whitespace removal in a separate patch from all the other changes.

Sorry for the delay in reviewing this… @thatcher has been swamped, and I'm just now getting involved.

iangilman commented 11 years ago

@acdha, Perhaps I'll take a look at cleaning these up?

iangilman commented 11 years ago

I've made a start: https://github.com/thatcher/openseadragon/commit/d1c02b45fe5d43e21b7fa321186c69286a2b2f93

acdha commented 11 years ago

I'll try to find some time to help out - I haven't touched our openseadragon code in several months and I believe there were some other worthwhile updates pending since the last time I updated.

iangilman commented 11 years ago

Awesome, that would be lovely. :-)

thatcher commented 11 years ago

Thanks to Ian for managing this process. I'm closing this since it's a long running issue not relatively attributed to a single contribution, but instead a generally iterative process.