thatcher / openseadragon

This project has moved to its new github organization at github.com/openseadragon, please join us!
http://openseadragon,github.com/
37 stars 14 forks source link

Pass the correct object to image load callbacks. #15

Closed Ventero closed 11 years ago

Ventero commented 12 years ago

Previously, the image object was passed on to onTileLoad regardless if it loaded successfully or not. In case an image failed to load, this would result in trying to draw a non-existing image onto the canvas, which (at least in Firefox) throws a DOM exception and results in the drawer being stuck mid-update.

iangilman commented 11 years ago

Great fix! Just a couple of comments:

Ventero commented 11 years ago

Thanks for reviewing the pull request. I've added a commit which updates the documentation and fixes the variable name. I hope the updated documentation makes sense - since English isn't my first language, feel free to correct me if something's wrong. ;)

iangilman commented 11 years ago

Looks great!