search

thatdot / quine

Quine • a streaming graph • https://quine.io • Discord: https://discord.gg/GMhd8TE4MR
https://quine.io
Other
301 stars 40 forks source link

Cypher: better detection of query anchors #28

Closed harpocrates closed 1 year ago

harpocrates commented 1 year ago

Some queries that should have been fully anchored weren't. The test that is added is an example: prior to this commit, that test fails since there is an all-node-scan

The issue boils down to not openCypher rewriting equality x = y into x IN [y] or y IN [x] and quine-cypher not recognizing all of those in the same way.

harpocrates commented 1 year ago

Base commit is a couple behind master since the UI seems broken in latest master - nodes and query results don't render on the canvas.

emanb29 commented 1 year ago

Thanks for the PR! We are aware of the issue on latest main, and it should be fixed in https://github.com/thatdot/quine/commit/8707ac1ade9006f8c28900eca4e6adc135710a21

emanb29 commented 1 year ago

Merged, thanks so much!