thathoff / kirby-git-content

Commit and Push changes made via the Panel
MIT License
136 stars 20 forks source link

'KirbyGitHelper::$git is deprecated' error on saving #98

Closed CHE1RON closed 1 year ago

CHE1RON commented 1 year ago

When saving, I get this Exception:

Unable to update git: Creation of dynamic property Thathoff\GitContent\KirbyGitHelper::$git is deprecated.

See here:

image

PHP: v8.2.6

thathoff commented 1 year ago

Thank you, that’s probably easy to fix. It should be possible to run this with PHP 8.2 when disabling deprecation notices in php be setting error_reporting = E_ALL & ~E_DEPRECATED in php.ini

CHE1RON commented 1 year ago

I wouldn't exactly call this a fix 😅 Alright then, what about people not being able to touch their php.ini or with limited access to .htaccess for that matter .. ?

thathoff commented 1 year ago

Sure, sorry, you’re absolutely right ;) What i tried to say is that the real fix is quite easy but in the meantime you can go with the mentioned hotfix to prevent this error from showing up.

CHE1RON commented 1 year ago

Ah, I get it - maybe I find some time to examine it, but in any case I appreciate your effort with this plugin, which has already proven quite helpful!

CHE1RON commented 1 year ago

Thanks @thathoff !

ericderid commented 1 year ago

I installed this plugin a few days ago but I still get this error message. See screenshot. I assume the fix mentioned above is included if I installed it a few days ago or not? How can I fix this. Thanks in advance!

Scherm­afbeelding 2023-06-13 om 14 14 06
thathoff commented 1 year ago

We have not made a new release yet which fixes the problem. If you install via composer try to use the version from master by requiring dev-master then it should work. Hopefully I’ll be able to create a new release in the next days.

ericderid commented 1 year ago

Ok thanks for the quick reply!

CHE1RON commented 1 year ago

Any particular reason not releasing v5.0.2 🤔

thathoff commented 1 year ago

Yes, time ;) But i’ve just released the new version 🥳

CHE1RON commented 1 year ago

🤩 now THAT is good news, fine Sir!