search

thathoff / kirby-git-content

Commit and Push changes made via the Panel
MIT License
136 stars 20 forks source link

fix: resolve the deprecated warning for KirbyGitHelper #99

Closed radibit closed 1 year ago

radibit commented 1 year ago

Description

The PR addresses the 'KirbyGitHelper::$git is deprecated' error as expressed in the #98

thathoff commented 1 year ago

Hi, thanks for you pull request. I think a better solution would be to define $git as a private property. There is no reason that this is not defined and the class does not need to support dynamic properties.

radibit commented 1 year ago

@thathoff Thanks for the suggestion. Let me know if the latest code change is what you had mind? I've tested it locally and it worked as expected.

thathoff commented 1 year ago

Thank you!