search

thatseant / pe

0 stars 0 forks source link

Wrong Error Message: Invalid event type message when command does not include semicolon #1

Open thatseant opened 4 years ago

thatseant commented 4 years ago

Error message does not match the error. The error is that the user does not include semicolons.

Steps to reproduce: 1) Command: add Timetable CS2113T Kitchen 20/04/2020 12:30 AM

Expected: Error message should indicate that semicolons are missing.

Actual: Error message shows that invalid event type is added.

Screenshot 2020-11-13 at 4.37.21 PM.png

With Semicolons, this command is valid. Screenshot 2020-11-13 at 4.37.35 PM.png

nus-pe-bot commented 4 years ago

Team's Response

Thank you for the bug report. The user guide shows that each field for the add command should end with a semicolon. image.png

I think the error message is suitable because it takes your input as the event type until a semi colon is placed to separate it from the other fields so I think it should be rejected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: An unclear error message affects the very first command. A typical user new to the app might miss out semicolons (especially given how Duke in iP works). This issue is compounded by the fact that some later commands do not have semicolons. It is very taxing to the user to remember which commands have semicolons and when mistaken, is failed to be notified of the appopriate error by the app.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: An unclear error message affects the very first command. A typical user new to the app might miss out semicolons (especially given how Duke in iP works). This issue is compounded by the fact that some later commands do not have semicolons. It is very taxing to the user to remember which commands have semicolons and when mistaken, is failed to be notified of the appopriate error by the app.