thatseant / pe

0 stars 0 forks source link

No error shown when event is already marked as done #4

Open thatseant opened 3 years ago

thatseant commented 3 years ago

An error should be shown when marking a completed event as done. Another error should be shown when marking an uncompleted event is undone.

Actual: The same status message for valid done and undone commands are shown.

Screenshot 2020-11-13 at 5.03.53 PM.png

nus-pe-bot commented 3 years ago

Team's Response

Thank you for the feedback. The event being marked done exists and is a valid event, and marking an already done event as done again does not affect functionality of the program. This goes for marking an undone event as undone as well. An error is currently not expected to appear for these use cases.

As this does not cause any inconvenience to the user, the severity is reduced. The implementing of errors for such use cases can be considered for future iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The team has mentioned that the implementing of errors for such use cases can be considered for future iterations. This bug should not be rejected.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: This might cause confusion to the user as he might think a completed task was not completed yet.