search

thatvugirl / homework-landingpage

Unit 2 Homework
0 stars 0 forks source link

Feedback on assignment 2 #1

Open barryross opened 6 years ago

barryross commented 6 years ago

FEWD Week #2 Project: Styling with CSS

Description

A hot, new NY Tech Startup, Relaxr, has approached you to help them develop a new landing page for their company. They've handed you the design file for the site, along with the copy and assets. You need to take these files and turn it into a landing page.

Student: Kelsey Vu

Project URL: https://github.com/thatvugirl/homework-landingpage
Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Use HTML5 structural elements (nav, header, footer) x
Use a reset.css or normalize.css file in addition to your style.css file to style the page x
Use IDs and Classes to to select and style elements on the page x
Use at least two flex containers, each with at least two flex items x
Style your text with the Google Fonts provided by your style guide n/a n/a n/a
Follow naming conventions, maintain consistency across .html and .css files and use best practices for naming IDs and Classes x
Indent nested elements to increase your code's readability x
TOTAL: 9/12
barryross commented 6 years ago

Hey Kelsey,

You are doing some great things here! Nice work on this second assignment! I notice you didn't include a reset.css or normalize.css file, and that's the reason for the marks off there. As for naming conventions, I encourage you to use all lowercase for filename. On that note (and something I realize I haven't stressed much in class), the homepage of a site is almost always going to be named index.html.

Other than that, I look forward to reviewing the Google Font tech requirement with your assignment 3 submission, and will revisit the rubric once I receive that.

Please see inline comments for additional info, and feel free to reach out with any questions!

Keep up the great work!