Closed caseykneale closed 3 years ago
Merging #114 (866e3bf) into master (6084bf7) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 28 28
Lines 1563 1563
=======================================
Hits 1387 1387
Misses 176 176
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6084bf7...866e3bf. Read the comment docs.
Thanks. I'm not a native English speaker, and as your PR is a bit large, I'd ask others to help me with review.
@MasonProtter Hi Mason, could you help here?
That is a good idea. I am a native English speaker, but, my English isn't always the best :)
No problem I had some free time come up and thought I'd put it to use.
I agree with pretty much all of your knit-picks.
Bigs thanks to @caseykneale and @MasonProtter ! Once Mason approve the PR I will merge it.
I am not in a hurry, just wanted to help :). Let me know if there's anything else I can do,
There are 29 commits, do you mind if I squash them? @caseykneale
I think maybe this should be reverted and squashed. That was a LOT of commits
I didn't operate it correctly, maybe you make a PR again?
Hi I am a Julia programmer who recently started learning functional programming. I think your package is really cool! I made some changes to the documentation. You do not have to accept them, but they, improve some of the grammar.
I feel your original documentation was good, but others may struggle to read some small parts in it.