search

thautwarm / MLStyle.jl

Julia functional programming infrastructures and metaprogramming facilities
https://thautwarm.github.io/MLStyle.jl/latest/
MIT License
404 stars 39 forks source link

added a fix for issue #89 and tests for @as_record. #90

Closed maxd13 closed 4 years ago

maxd13 commented 4 years ago

Tests are passing in both version 1.4.2 and 1.3.1

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into master will increase coverage by 0.13%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   90.20%   90.34%   +0.13%     
==========================================
  Files          28       28              
  Lines        1338     1336       -2     
==========================================
  Hits         1207     1207              
+ Misses        131      129       -2
Impacted Files Coverage Δ
src/Record.jl 94.54% <ø> (+3.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fc1205...b6a525c. Read the comment docs.

thautwarm commented 3 years ago

Thanks again for the impressive notes about expression problem. I'd like to add it to documentations.

Besides, your git config seems broken, so that you were not recorded at https://github.com/thautwarm/MLStyle.jl/graphs/contributors. I'd recommend you to set email via git config (--global) user.email xxx@xxx.

To add you to the contributors, I'm to fix the git tree because I don't want to loss a conscientious contributor.