thaw-ui / thaw

An easy to use leptos component library
https://thawui.vercel.app
MIT License
278 stars 33 forks source link

Icon should be `display: inline-block` #172

Closed tqwewe closed 5 months ago

tqwewe commented 5 months ago

Since icons are typically used besides text or a label, it might make sense to add display: inline-block?

luoxiaozero commented 5 months ago

I feel that the behavior of Icon is the same as that of inline-block. Why add it? Can you give me an example?

tqwewe commented 5 months ago

I'm using tailwindcss in my project with Thaw, and the css reset for tailwind sets svg { display: block; }. But whenever I use Thaw icons, I always need to add class="inline-block" to fix the icons due to the reset. I'm quite sure many other people would use tailwind with Thaw and have the same issue

luoxiaozero commented 5 months ago

Understood, we can add display: inline-block to Icon.