search

thaw-ui / thaw

An easy to use leptos component library
https://thawui.vercel.app
MIT License
205 stars 21 forks source link

Default button should not be primary #181

Open tqwewe opened 2 months ago

tqwewe commented 2 months ago

The default button variant seems to be Primary, however this isn't typically the most common button variant, and comparing with Pigment, Naive UI, and AntDesign, they all default to a more basic white button.

Additionally, I noticed that the default outlined button does not have a background color. Would it be preferred to have a background color for the default button similar to AntDesign and Pigment UI? This makes the most sense imo, since sometimes you might have a button over a slightly gray background, and want the button itself to be white, but there doesn't seem to be any way to add this without adding your own styles.

luoxiaozero commented 2 months ago

I feel more and more that Thaw needs a design language to guide it to avoid more problems like this in the future.

I'm currently bullish on Fluent UI. I want to make Thaw's design style tend to be Fluent UI in the future, but it doesn't have to be 100% similar.

tqwewe commented 2 months ago

Honestly, having a kind of port of Fluent UI to Leptos Rust would be so great imo. I feel a little that a lot of the values chosen for styles such as padding etc aren't too consistent in Thaw, whereas using something similar to Tailwind with fixed increments of sizings and such would give more consistency.