search

thaw-ui / thaw

An easy to use leptos component library
https://thawui.vercel.app
MIT License
278 stars 33 forks source link

Allow label from Autocomplete to be any type that impl IntoView #201

Closed heyjul closed 4 months ago

heyjul commented 4 months ago

Hi there, is there a reason why the label of the Autocomplete component only allow String and not any type that impl IntoView ? With this change, it would be possible to customize the options (like adding an image or whatever). I would be happy to make the change as I already did it for myself.

luoxiaozero commented 4 months ago

Hi there, is there a reason why the label of the Autocomplete component only allow String and not any type that impl IntoView ?

This is a problem left over from history.

I would be happy to make the change as I already did it for myself.

Very welcome.

heyjul commented 4 months ago

Can't think of a way to implement this without breaking changes.