search

thaw-ui / thaw

An easy to use leptos component library
https://thawui.vercel.app
MIT License
206 stars 21 forks source link

Allow label to be any type that impl IntoView #203

Closed heyjul closed 1 month ago

heyjul commented 1 month ago

201

heyjul commented 1 month ago

I see that the builds fails, I will try to fix that later today

luoxiaozero commented 1 month ago

I think the build failed because it was a breaking change.

heyjul commented 1 month ago

Yes it is indeed. I thought that it would not be a breaking change since String implements the necessary traits and since the type can be inferred but I didn't think about return types of a function. Now that I think about it, it will probably be a problem even when no options are passed down to the AutoComplete.

Since it is a breaking change, is it still a desired change ?

heyjul commented 1 month ago

Can't think of a way to implement this.

luoxiaozero commented 1 month ago

I will change it in version 0.4.