search

thawn / ttmp32gme

a tool to create tiptoi gme files from mp3 files. Also creates a printable sheet to play the music.
MIT License
193 stars 28 forks source link

Can't add albums to library #45

Open DuwenBlade opened 3 years ago

DuwenBlade commented 3 years ago

Hi,

I'm using the latest release on W10, but I'm having a problem with adding any files to my library, so I can't create anything. This is the problem, that ttmp32gme writes back to me:

copying albums to library unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91718d0), AnyEvent::HTTPD::Request=HASH(0x917cd40)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

I changed already name of the file and set library to C:\Tiptoi, but it didn't help. Name Tag is there as well. I tried many files, but no success.

thawn commented 3 years ago

Thank you very much for reporting this issue. In order to be able to track down the cause, I will need a bit more information:

With that information, I can try to reproduce the issue on my test VM. Once I am able to reproduce it, I should also be able to fix it.

DuwenBlade commented 3 years ago

I don't know how is it possible, but I deleted all the files related to the programm and started it again. I set new directory for GME files and since than it works flawlessly. If it happens again, I'll copy it a post it whole.

DuwenBlade commented 3 years ago

OK it worked only for a moment, but now it stopped. Here is the report.

Use of uninitialized value $ENV{"HOME"} in concatenation (.) or string at Music/Tag.pm line 1066, <DATA> line 1.
[MSG] Server running on port: 10020
Open http://127.0.0.1:10020/ in your favorite web browser to continue.

[MSG] using tttool: C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe
copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\2\Chytra horakyne.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
deleting C:\Tiptoi\temp
C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe --dpi 1200 --pixel-size 2 assemble Chytra_horakyne.yaml
[MSG]
C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe --dpi 1200 --pixel-size 2  --code-dim 24 oid-code 921
[MSG] Writing oid-921.png.. (Code 921, raw code 14104)

C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\wkhtmltopdf.exe -B 0.5in -T 0.5in -L 0.5in -R 0.5in http://localhost:10020/pdf "C:\Tiptoi\print.pdf"
Qt: Untested Windows version 10.0 detected!
Loading page (1/2)
Printing pages (2/2)
Done
copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Kostlivec.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
deleting C:\Tiptoi\temp
C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe --dpi 1200 --pixel-size 2 assemble Kostlivec.yaml
[MSG]
C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe --dpi 1200 --pixel-size 2  --code-dim 24 oid-code 922
[MSG] Writing oid-922.png.. (Code 922, raw code 14106)

C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\wkhtmltopdf.exe -B 0.5in -T 0.5in -L 0.5in -R 0.5in http://localhost:10020/pdf "C:\Tiptoi\print.pdf"
Qt: Untested Windows version 10.0 detected!
Loading page (1/2)
Printing pages (2/2)
Done
copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Neposlušný hajzlpapír.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91ab9f8), AnyEvent::HTTPD::Request=HASH(0x93f7f08)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Neposlušný hajzlpapír.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91ab9f8), AnyEvent::HTTPD::Request=HASH(0x940f710)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Neposlušný hajzlpapír.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91ab9f8), AnyEvent::HTTPD::Request=HASH(0x9810698)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Neposlušný hajzlpapír.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91ab9f8), AnyEvent::HTTPD::Request=HASH(0x9806bb0)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

copying albums to library
[ERROR] WARNING: id3 tag missing or incomplete for C:\Tiptoi\temp\1\Neposlušný hajzlpapír.mp3.
Please add an id3v2 tag containing at least album, title and track number to your mp3 file in order to get proper album and track info.
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x91ab9f8), AnyEvent::HTTPD::Request=HASH(0x980c9e8)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.
thawn commented 3 years ago

@DuwenBlade thank you very much for the log outputs. Based on the log outputs I see two potential causes for the issues:

  1. A codepage issue with accented characters. I see that you have accented characters like š and ý in the filenames. Try to replace these characters with non-accented characters like s and y and check whether the problem goes away. You may need to delete the old ttmp32gme data
  2. Missing id3v2 tags. the tag version v2 is important (v1 truncates the titles). Try a id3 tag editor like mp3tag to check for the tag version.

I just recently added support for non-ascii characters in filenames and tags. However, I only tested this with german umlauts like ä ö ü, not with accented characters.

Could you please upload a single test file here, so that I can reproduce and hopefully fix the problem? Could you please tell me which codepage your windows installation is using (you can check by opening a command line window and enter the command chcp). Thanks!

DuwenBlade commented 3 years ago

ad 1. I replaced the charecters with non-acented ones.

ad 2. I added ID3v2 Tag with filename,, album, interpret and song number.

I deleted all the files connected with ttmp32gme in local and roaming and still get this error:

Use of uninitialized value $ENV{"HOME"} in concatenation (.) or string at Music/Tag.pm line 1066. [MSG] Server running on port: 10020 Open http://127.0.0.1:10020/ in your favorite web browser to continue.

[MSG] using tttool: C:\Users\PEKOVI~1\AppData\Local\Temp\par-5065c5a16b6f7669\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe copying albums to library unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x925c620), AnyEvent::HTTPD::Request=HASH(0x9265da0)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

My windows codepage is 65001. Here is my testing file. I recorded it myselve for my kids.

Neposlusny hajzlpapir.zip

acetous commented 3 years ago

I got exactly the same issue.

Use of uninitialized value $ENV{"HOME"} in concatenation (.) or string at Music/Tag.pm line 1066, <DATA> line 1.
[MSG] Server running on port: 10020
Open http://127.0.0.1:10020/ in your favorite web browser to continue.

[MSG] using tttool: C:\Users\SEBAST~1\AppData\Local\Temp\par-53656261737469616e\cache-79be178b2945f1b0b8b1dcc94b3b41a083d99cb8\inc\lib\tttool.exe
copying albums to library
unhandled callback exception on event (/, AnyEvent::HTTPD=HASH(0x923f0c8), AnyEvent::HTTPD::Request=HASH(0x94859f8)): Can't call method "basename" on an undefined value at TTMp32Gme/Build/FileHandler.pm line 107.

I noticed that only the first two songs are imported to the album, it seems to crash on the third file. Here are the names of the file.

Maybe it's an encoding issue? ;) I'm using ttmp32gme-1.0.0 on Windows 10.

thawn commented 3 years ago

The filename in the temp folder looks like it is an encoding issue, which is weird, because the exact same filename works fine on my test system. Did you by any chance activate the Beta UTF-8 mode? (under Region settings check if the "Beta: Use Unicode UTF-8 for worldwide language support" checkbox is checked). If yes, could you please try if it works if you uncheck that box and try again?

acetous commented 3 years ago

It took me a while to notice that you meant the region settings of Windows 10. The UTF-8 beta support ist not set. As a workaround I just renamed the original files.

JensHoRi commented 3 years ago

In my case it had been a german ß in the Title of the mp3. Maybe this information helps

juli-august commented 2 years ago

In my case it had been also a german ß and also a capital Ü

thawn commented 2 years ago

Unfotunately, proper character encoding in Perl under Windows is a nightmare. I will try to fix the issue, but it may take a while.