search

thbar / kiba

Data processing & ETL framework for Ruby
https://www.kiba-etl.org
Other
1.75k stars 87 forks source link

Readme tweak #2

Closed ollie closed 9 years ago

ollie commented 9 years ago

Hello,

it is not necessary to use file extension in require and it feels non-idiomatic. Therefore I thought I'd make a PR, if that's okay for such a small change. :-)

Ollie

thbar commented 9 years ago

Hi Ollie! Thanks for pointing that out! Non idiomatic indeed.

I checked my ETL script for an upcoming article and it actually seems that you'd even need something else: either require './common' or require_relative 'common', for this to work for real, as require 'common' will raise cannot load such file unless you tweak the $LOAD_PATH.

I'd go for require_relative here since it feels better. What do you think?

ollie commented 9 years ago

Yes indeed, require_relative sounds even better. :smile:

thbar commented 9 years ago

You change has been merged into master (b6e02414448c8a9eaa0fd91aa60ffc2c4d4c8b74). Thanks Ollie!

ollie commented 9 years ago

No problem, thanks too. :)