thbar / kiba

Data processing & ETL framework for Ruby
https://www.kiba-etl.org
Other
1.75k stars 87 forks source link

Fix JRuby 1.9 broken tests #54

Closed thbar closed 6 years ago

thbar commented 6 years ago

It looks like for JRuby 1.9 only, the tests previously failed because an old version of minitest (5.4.1) is loaded (presumably bundled with JRuby itself), instead of the latest version of minitest (5.1.13).

Link: https://travis-ci.org/thbar/kiba/jobs/378476433

Logs:

$ bundle install
Installing minitest 5.11.3

$ bundle exec rake
Running with MiniTest version 5.4.1

Since I couldn't find a way to load the latest version with JRuby 1.9, I instead implemented the missing bits in the old version of minitest (assert_mock) for now to fix the build.

I will try to provide a full reproduction to the JRuby project - maybe it's a known behaviour by the way.