thbar / kiba

Data processing & ETL framework for Ruby
https://www.kiba-etl.org
Other
1.75k stars 87 forks source link

Improperly detects nil, as block #70

Closed envygeeks closed 5 years ago

envygeeks commented 5 years ago

Given

Kiba.run(Kiba.parse do
  source MySource
  destination MyDestination
  transform nil
end)

Kiba will throw an error that "Class and block form cannot be used together at the moment", but nil is not a block, it should throw a unique error that it found neither a block, or transformer.

thbar commented 5 years ago

Thanks Jordon! I will improve that!

Envoyé de mon iPhone

Le 19 avr. 2019 à 13:25, Jordon Bedwell notifications@github.com a écrit :

Given

Kiba.run(Kiba.parse do source MySource destination MyDestination transform nil end) Kiba will throw an error that "Class and block form cannot be used together at the moment", but nil is not a block, it should throw a unique error that it found neither a block, or transformer.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

thbar commented 5 years ago

@envygeeks thanks again for the input ; I fixed this in #73 (which will be release into kiba 2.5), and will work at improving parse-time error messages in the future.

Many thanks!

envygeeks commented 5 years ago

Thanks!