search

thbar / kiba

Data processing & ETL framework for Ruby
https://www.kiba-etl.org
Other
1.75k stars 87 forks source link

Ruby 2.7+ compatibility (keyword arguments) #85

Closed thbar closed 4 years ago

thbar commented 4 years ago

Due to the recent changes announced here:

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

(and tracked here initially https://bugs.ruby-lang.org/issues/14183)

it is possible to get warnings (and later with Ruby 2.8+, most likely errors), depending on how the components are implemented (and this is the case with kiba-common, for instance).

I'm opening this issue to track this down.

For now I would recommend to stick with Ruby 2.6 if possible.

thbar commented 4 years ago

I've started working on proper support on branch ruby-3-compat-keyword-arguments. WIP and will require large testing.

thbar commented 4 years ago

kiba-common preview compatibility branch is also available at https://github.com/thbar/kiba-common/pull/27. This will need real life testing.

thbar commented 4 years ago

Ruby 2.7 compatibility is available in master.

A new release will be published later with corresponding changes.

thbar commented 4 years ago

Release v3.5.0 has been published. Closing!