thbar / kiba

Data processing & ETL framework for Ruby
https://www.kiba-etl.org
Other
1.75k stars 87 forks source link

Ruby 3.0 keyword arguments compatibility (pass two) #93

Closed thbar closed 4 years ago

thbar commented 4 years ago

This PR fixes Kiba ETL keyword arguments support for Ruby 2.7+ (and replaces #86 which is a previous attempt I wasn't completely happy with). See #85 for initial issue.

This works equally with Ruby 2.7.1 and current Ruby master (2.8.0-dev in rbenv, with ruby -v giving 3.0.0dev).

Decision

Special thanks to @eregon and @mame for their valuable input during the past few months.

I have decided for now to use ruby2_keywords like Rails does, which means:

Relevant literature

thbar commented 4 years ago

Tested fine on a reasonably complex ETL setup. I'll merge.