thbe / puppet-ssmtp

Puppet ssmtp module
https://thbe.github.io/puppet-ssmtp/
GNU General Public License v3.0
1 stars 15 forks source link

Stdlib 4.1 dependency makes ssmtp uninstallable on Puppet Enterprise #1

Closed cbarbour closed 10 years ago

cbarbour commented 10 years ago

The SSMTP module is hard coded to require stdlib 4.1.0 or above, but doesn't seem to depend on any 4.x specific functionality.

Puppet Enterprise ships with a specific release of stdlib, and has dependencies that make upgrading stdlib virtually impossible. It's impossible to satisfy the stdlib 4.1.0 dependency on Puppet Enterprise 3.1

I recommend changing the requirement to stdlib 0.1.6 or above. This is the release that introduces anchor types.

It's probably unnecessary to include stdlib. This action only seems to be useful for setting up various run-stages, which the ssmtp module doesn't depend on.

Check the stdlib changelist: http://forge.puppetlabs.com/puppetlabs/stdlib

thbe commented 10 years ago

It is true that the feature was introduced with 0.1.6, but based on the git repository it was enhanced around version 2.1.x, so I would tend to set 2.2 and greater as a prerequisite. Will this work with PE?

cbarbour commented 10 years ago

That should be fine. PE 2 ships with stdlib 2.3. I don't see a good reason to support older release of PE than that.

BTW, this is an awesome module. I forked it because I intended to use it as part of a demonstration/lesson plan.

thbe commented 10 years ago

Thanks for the compliment! The fixed module is pushed as version 0.2.1 to forge.puppetlabs.com. Open a new bug report if it still didn't work.