search

thblt / write-yourself-a-git

Learn Git by reimplementing it from scratch
https://wyag.thb.lt
GNU General Public License v3.0
655 stars 75 forks source link

Fix test nondeterminism from git config and timezones #27

Closed charlie-collard closed 3 years ago

charlie-collard commented 3 years ago

The lack of GIT(COMMITTER|AUTHOR)(NAME|EMAIL) environment variables, and the lack of a timezone in the DATE variables caused the tests to fail on my machine :)

thblt commented 3 years ago

Thanks you! I added an extra commit just to use a more neutral name.

charlie-collard commented 3 years ago

@thblt Cool! I think you'll need to update the commit hash though.

thblt commented 3 years ago

Erm, yes, of course. Fixed. Thanks again.

charlie-collard commented 3 years ago

No worries. I love the project btw, I recommend it to coworkers all the time. I found it incredibly valuable, so thank you :)