thchia / react-oidc

Wrapper for the OIDC JavaScript client, to be used in React projects
48 stars 10 forks source link

oidc-react and react-oidc #28

Open simenandre opened 4 years ago

simenandre commented 4 years ago

Hello!

I'm currently maintaining oidc-react. Our projects utilize a lot of the same structure, maybe we should combine forces?

I think it is important to have an easy to get started oidc-client-based React package. Such as, honestly, both of our packages do. I don't need to put our company logo on anything, and I'll happily depreciate ours for yours (maybe with some changes). Maybe we should actually create an organization and be open for others to take a more active part in it?

I don't know, just wanted to get your opinion on it. :)

thchia commented 4 years ago

Hello @cobraz - I am so sorry that I did not get back to you on this sooner. If this endeavour is still of interest to you I have no problem adding you as a collaborator on this project?

simenandre commented 4 years ago

Maybe we can schedule a quick chat? I'll be happy to work on it 👍

miguelzakharia commented 3 years ago

Did you decide to combine the two repos?

simenandre commented 3 years ago

We haven't been able to have a chat about it. Since this issue was created oidc-react has received much interest and a new co-maintainer, that I'd like to join this discussion, @ryancole :)

ryancole commented 3 years ago

What's the proposal? I'm not familiar. It seems we have two libraries focused on the same thing.

Personally, I chose oidc-react due to the hook nature of it. So perhaps that's some sort of common ground that could be made in terms of joining forces?

I'm not sure what the end goal here is, though.

@cobraz sounds like he's open to merging his repo with react-oidc. If that were the case, then hooks would be a thing I'd be looking for.