thclark / sphinx-charts

Interactive charts in sphinx HTML docs, using plot.ly and D3
MIT License
26 stars 3 forks source link

upgrading depenencies to also work with Sphinx 4 #11

Closed TooDissing closed 2 years ago

TooDissing commented 2 years ago

Fixes #10.

TooDissing commented 2 years ago

Hopefully this last commit is a little better. Needed to upgrade additional parts to make it work. Also not sure that the tests caught the bug in the first commit...so maybe good to validate against Sphinx 2 and 3.

thclark commented 2 years ago

@LydByDissing I've got a bear of a day on today (grant application due for octue) but will do a final check of this for Sphinx 2/3 tomorrow and release it. Thanks for your help!

Tom

TooDissing commented 2 years ago

Hi Tom,

No stress - I can work. So do it in your time :-)

With regards

Tue Dissing CEO and founder Lyd by Dissing

+45 20 68 33 02 @.***

Den 14. jan. 2022 kl. 09.46 skrev Tom Clark @.***>:

@LydByDissing https://github.com/LydByDissing I've got a bear of a day on today (grant application due for octue) but will do a final check of this for Sphinx 2/3 tomorrow and release it. Thanks for your help!

Tom

— Reply to this email directly, view it on GitHub https://github.com/thclark/sphinx-charts/pull/11#issuecomment-1012921367, or unsubscribe https://github.com/notifications/unsubscribe-auth/APEQ2MUFLBYSMW7VEL7S2ADUV7PEXANCNFSM5L4G644A. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.

codecov-commenter commented 2 years ago

Codecov Report

Merging #11 (56ca798) into master (117e6f0) will decrease coverage by 0.42%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   20.14%   19.71%   -0.43%     
==========================================
  Files           1        1              
  Lines         139      142       +3     
==========================================
  Hits           28       28              
- Misses        111      114       +3     
Impacted Files Coverage Δ
sphinx_charts/charts.py 19.71% <0.00%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 117e6f0...56ca798. Read the comment docs.

thclark commented 2 years ago

Woops closed accidentally triggered by me switching from 'master' to 'main'. Sorry @LydByDissing - I'll resurrect this and am just getting it merged now.