thdoan / magnify

A lightweight jQuery magnifying glass zoom plugin.
https://thdoan.github.io/magnify/
MIT License
243 stars 63 forks source link

Cant scroll down when magnify is on full screen image. #55

Open EvanCowan opened 5 years ago

EvanCowan commented 5 years ago

Im using magnify on large images on my site. It works well, but on mobile, the lens appears when i try and drag the page down, instead of the page scrolling down. Id rather just have a tap to enlarge on mobile without the lens, which Im hoping will sort the scrolling issue. Is that possible?

thdoan commented 5 years ago

Have you tried the mobile plugin? It is meant to be used on mobile (the main plugin is meant for desktops):

https://thdoan.github.io/magnify/demo-mobile.html

EvanCowan commented 5 years ago

Yeah, I have the mobile min js loaded, but do I need to do something else? Preview a page here: https://www1.sentinelhomes.co.nz/floor-plans-2a I see the lens come up on android chrome.

benlau87 commented 5 years ago

Same problem here. Mobile plugin loaded, but scrolling not possible when the image covers the whole screen :-(

thdoan commented 5 years ago

This is the mobile plugin's intended behavior. To scroll, close the overlay.

On Sun, Apr 14, 2019, 12:35 PM benlau87 notifications@github.com wrote:

Same problem here. Mobile plugin loaded, but scrolling not possible when the image covers the whole screen :-(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thdoan/magnify/issues/55#issuecomment-483047867, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6459SQr6jaQ0l0Cldh8exCACQGba2_ks5vg4MRgaJpZM4aP6Cm .

benlau87 commented 5 years ago

But how do you close the overlay? There is no close icon and I am not getting any errors: https://www.sm-55.de/reinigungsmittel-pflegemittel/fussbodenpflege/hart-bohnerwachs-rotbraun-fluessig-10l

thdoan commented 5 years ago

Hmm...the page you linked to is not using the mobile plugin. The mobile plugin experience is like this:

https://thdoan.github.io/magnify/demo-mobile.html

On Mon, Apr 15, 2019, 1:28 PM benlau87 notifications@github.com wrote:

But how do you close the overlay? There is no close icon and I am not getting any errors:

https://www.sm-55.de/reinigungsmittel-pflegemittel/fussbodenpflege/hart-bohnerwachs-rotbraun-fluessig-10l

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thdoan/magnify/issues/55#issuecomment-483405931, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6455mL31D-ZUhTxq61BfGfCeINjgHvks5vhODZgaJpZM4aP6Cm .

benlau87 commented 5 years ago

But in the demo I am having the same issue. Not always the first time, but happens nearly every time. I guess its dependant on the "swipe technique" or even mobile device?

thdoan commented 5 years ago

What exactly is the issue, you're not seeing the "x" icon in the overlay?

Are you even seeing the overlay? If you see the circular lens, then that's not the mobile overlay -- that's the desktop version.

On Mon, Apr 15, 2019, 2:39 PM benlau87 notifications@github.com wrote:

But in the demo I am having the same issue. Not always the first time, but happens nearly every time. I guess its dependant on the "swipe technique" or even mobile device?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thdoan/magnify/issues/55#issuecomment-483428971, or mute the thread https://github.com/notifications/unsubscribe-auth/AD645zWBTLwrr-RjSPjJrT0KB1faouixks5vhPGMgaJpZM4aP6Cm .

benlau87 commented 5 years ago

I am not getting the mobile overlay then. Phone: Xiaomi Mi 5, Android 8 (MIUI Global 10.2 Stable)

thdoan commented 5 years ago

Thanks for reporting this. Can you see if you can reproduce the issue in Chrome by using the device emulation feature? I don't have a Xiaomi phone so let's try to reproduce it this way instead.

On Mon, Apr 15, 2019, 2:53 PM benlau87 notifications@github.com wrote:

I am not getting the mobile overlay then. Phone: Xiaomi Mi 5, Android 8 (MIUI Global 10.2 Stable)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thdoan/magnify/issues/55#issuecomment-483432815, or mute the thread https://github.com/notifications/unsubscribe-auth/AD645_Upjq1m_Pp-CteaIdWihd_fbCm6ks5vhPTUgaJpZM4aP6Cm .

ghost commented 3 years ago

Hi,

Same problem here.

The problem is not the overlay. The problem is you can't touch your screen to scroll down if the picture is full screen (not the overlay, le picture). So, the magnify js takes place instead of the scroll.