search

the-13th-letter / derivepassphrase

an almost-faithful Python reimplementation of James Coglan's vault, a deterministic password manager/generator
MIT License
0 stars 0 forks source link

Remove Pageant build info check #14

Open the-13th-letter opened 1 week ago

the-13th-letter commented 1 week ago

In https://github.com/the-13th-letter/derivepassphrase/issues/12#issuecomment-2366806215, we encountered a bug in Pageant where the agent socket becomes undiscoverable if Pageant is spawned as a subprocess, in debug mode. We wrote and submitted a patch to upstream PuTTY, which will hopefully make it into PuTTY 0.82. 63b51df7a39fd642ca079ac390014d23f617b972 introduced a check for a fixed version of Pageant by asserting a version number 0.82 or greater, or by the presence of a specific build identifier. This check further enables running Pageant in foreground mode, which is a small feature request related to and submitted together with the patch above.

Of course, this version check in its current form is only a temporary measure, and there is no guarantee that 0.82 will be the first version where the bug is fixed or the foreground mode feature is implemented, if at all. The local build identifier check furthermore assumes that Pageant's version number adheres to PEP 440, which is not guaranteed by upstream PuTTY, neither in format nor in semantics.

Therefore, once a fixed version of PuTTY has been released, remove the build identifier checks and update the minimum required version to whatever version number the fixed PuTTY version has. If necessary, adapt the version comparison code as well.

the-13th-letter commented 6 days ago

In #12 (comment), we encountered a bug in Pageant where the agent socket becomes undiscoverable if Pageant is spawned as a subprocess, in debug mode. We wrote and submitted a patch to upstream PuTTY, which will hopefully make it into PuTTY 0.82. 63b51df introduced a check for a fixed version of Pageant by asserting a version number 0.82 or greater, or by the presence of a specific build identifier. This check further enables running Pageant in foreground mode, which is a small feature request related to and submitted together with the patch above.

The "undiscoverable socket in debug mode" bug has been fixed upstream in fca6ce10dbf01e57ec4777b87faae8b38e53ff43, and foreground mode has been introduced in 2b93417398f641e410f0b3564135508ebfb71ac0. Both commits should be included in PuTTY 0.82.