search

the-after-hours / contri-credit

Give contribution credit where contribution credit is due
MIT License
1 stars 0 forks source link

Quick refactor #2

Closed jwu910 closed 6 years ago

jwu910 commented 6 years ago

@rainrivas Check out these changes, let me know what you think. Axios footprint seemed much smaller than request, and also made it a little easier for me to play with the api

todo[bot] commented 6 years ago

Check for existing CONTRIBUTORS.md

We should prompt the user to continue if they are about to overwrite a file

https://github.com/the-after-hours/contri-credit/blob/6e4f4d817a2baae18ca78479a82c2b045ad3b709/index.js#L75-L80

This comment was generated by todo based on a @todo comment in 6e4f4d817a2baae18ca78479a82c2b045ad3b709 in #2. cc @the-after-hours.
rainrivas commented 6 years ago

@jwu910 i'm still reviewing this but I was curious as to why axios is objectively better. I'm cool using it just wanted to understanding why we switching it up. Also have a few other questions but I'll throw those onto the PR as I go along with the review.

jwu910 commented 6 years ago

Sounds good, I can update when I get home, or if you want, you can add it in too

todo[bot] commented 6 years ago

Check if we can pull contributors from branches other than master

Currently we only pull the contributors from master, this means that whenever someone

https://github.com/the-after-hours/contri-credit/blob/4845586840a88bc13d7e1b7929150461a7f318a4/index.js#L18-L23

This comment was generated by todo based on a @todo comment in 4845586840a88bc13d7e1b7929150461a7f318a4 in #2. cc @the-after-hours.