the-badger / badger

Gamification platform to motivate your team with badges, adventures & other cool stuff!
MIT License
80 stars 9 forks source link

[question] Where to put inheritence interface? #79

Open pierallard opened 8 years ago

pierallard commented 8 years ago

I've done this:

https://github.com/akeneo/badger/blob/master/src/Badger/GameBundle/Entity/BadgeInterface.php#L15

But another possibility is to remove "extends TaggableInterface" from this interface, and add "implements TaggableInterface" to "Badge".

I think these 2 implementations are "code-correct", but have not the same "coding sense".

What's your opinion ?