Program fails to convert songs with symbols in the name

the-batfish / spotify-downloader

Download songs,playlists and even albums from spotify within a matter of seconds in a variety of different formats like m4a,mp3,wav and even flac with spotify downloader

GNU General Public License v3.0

296 stars 29 forks source link

Program fails to convert songs with symbols in the name #2

Closed marcopg99 closed 2 years ago

marcopg99 commented 3 years ago

When the song has "/" in the name (AC/DC for example):

Couldnt convert song [Errno 2] No such file or directory : file path.mp3

When the song has "?" in the name:

Couldnt convert song [Errno 22] Invalid argument: file path.mp3

marcopg99 commented 3 years ago

When it has ":" in the name, a file without extension is left in the download directory. No error message shown

Vildis commented 3 years ago

Windows doesn't allow the following characters in filenames:
/ \ ? % * : | < and > Wikipedia

Easiest fix is just to remove them in the code.

Vildis commented 3 years ago

Removing the characters might not work in all cases if the song name is only symbols. No clue what to do then, song name would still show in file metadata.

rickyrorton commented 2 years ago

i did encounter the same problem and fixed it only for one character, ill do for the others too