the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.91k stars 641 forks source link

Add CherryPy framework #1802

Closed murilobr closed 4 years ago

murilobr commented 4 years ago
waghanza commented 4 years ago

Hi @webknjaz,

Would you mind to add (or consent that we add) cherrypy in here ?

This project compare performance based on 3 routes :

Regards,

murilobr commented 4 years ago

I would like that you add.

webknjaz commented 4 years ago

@waghanza I don't mind. But I'm not an original author. I'm an active maintainer, though.

@murilobr feel free to ping me for review.

waghanza commented 4 years ago

@webknjaz Could you ping the original author (need to have consent, or at least a non opposition)

webknjaz commented 4 years ago

He is no longer active in the community. But you can try emailing him @ remi {AT} cherrypy {DOT} org. FWIW there's not much code in the repo that has survived from those times. It's been over a decade.

waghanza commented 4 years ago

@webknjaz I understand. I just want not to add any friction in cherrypy community :heart:

Lawouach commented 4 years ago

Indeed. Rémi will see no issue here and has left the project years ago. No need to reach out I'd say :)

Lawouach commented 4 years ago

Please could you stop spamming the mailing list however. There is no need for it.

waghanza commented 4 years ago

Oops, sorry. The web interface said there was an error, sorry for this mis-adventure.

@Lawouach No objection that we add cherrypy here ?

Lawouach commented 4 years ago

No worries. Messages are pending review when it's your first message.

I have none but @webknjaz is better suited to answer as he is a current maintainer. I was a long time ago :)

waghanza commented 4 years ago

@webknjaz Thanks for approval

@murilobr Any PR will be :heart:

murilobr commented 4 years ago

@waghanza I will try to do something. No time those days, but I will try. Thanks for your effort.

murilobr commented 4 years ago

@webknjaz could you please check this implementation? https://github.com/murilobr/web-frameworks/tree/cherrypy/python/cherrypy

@waghanza Could you check if it is according to the rules?

waghanza commented 4 years ago

Hi @murilobr,

Could you make a PR ? so as we can focus on what to fix

btw, thanks for participating

webknjaz commented 4 years ago

I'd prefer to work with a PR view as I would be able to comment on specific lines.

webknjaz commented 4 years ago

P.S. Why do you use gunicorn?

murilobr commented 4 years ago

P.S. Why do you use gunicorn?

Because other implementations in this project are using it.

I will create the PR.

webknjaz commented 4 years ago

Because other implementations in this project are using it.

Is it required by some policy? I'm just trying to figure out what is it being benchmarked.

murilobr commented 4 years ago

Because other implementations in this project are using it.

Is it required by some policy? I'm just trying to figure out what is it being benchmarked.

No there isn't. I think that we just have to use the most performatic implementation and I just used gunicorn because the majority of the python projects in this are using it. If you want you can change or suggest a better implementation.

webknjaz commented 4 years ago

There's no such thing as better or worse. But it cheats the benchmark in a way.