the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.91k stars 642 forks source link

[DNM] Run targeted apps into containers #180

Closed waghanza closed 6 years ago

waghanza commented 6 years ago

Hi,

This PR run all frameworks into docker containers.

In order to build and run :

shards install && shards build --release --no-debug # <- build all tools
bin/neph # <- build and run all containers
bin/benchmarker # <- run benchmarks

@tbrand I have disabled crillo, since only on OS X.

Regards,

tbrand commented 6 years ago

Hmm, other images seem too big for the reason as well. Could you minimize them by avoiding

COPY . .

It includes binary and logs as well.

waghanza commented 6 years ago

I personnaly use make to remove logs files, and else

make clean
shards install
shards build --release --no-debug
make all
bin/benchmarker --record
tbrand commented 6 years ago

Does it make sense?

Now we're building containers by make. So clean action should clean the containers.

I don't require the implementation for the clean at this PR. But I say the clean action might be changed so it cannot guarantee that we can build the clean and minimum containers.

Please avoid COPY . . since it's too lazy implementation... :pray:

waghanza commented 6 years ago

@tbrand We can also call clean implicitly. While the results computation will be stabilized, I'll plan to clean the build process (avoid to have 1 Dockerfile per project, but 1 but language)

tbrand commented 6 years ago

@waghanza I can work on it. Could you open the PR from the origin branch? (not forked one.) Then I can push the patches on it.

waghanza commented 6 years ago

done in #186

tbrand commented 6 years ago

I can work on it.

I mean I can work on avoiding the lazy implementation in Dockerfile. (Not for the clean action.) Ok, anyway, I'll push patches for it. Please wait for it.

tbrand commented 6 years ago

Let me close this PR since I've push the patches at https://github.com/tbrand/which_is_the_fastest/pull/187

If you have more patches, please push directly on #187 Thanks for the great works!