Closed waghanza closed 6 years ago
Hmm, other images seem too big for the reason as well. Could you minimize them by avoiding
COPY . .
It includes binary and logs as well.
I personnaly use make
to remove logs files, and else
make clean
shards install
shards build --release --no-debug
make all
bin/benchmarker --record
Does it make sense?
Now we're building containers by make
.
So clean
action should clean the containers.
I don't require the implementation for the clean
at this PR.
But I say the clean action might be changed so it cannot guarantee that we can build the clean and minimum containers.
Please avoid COPY . .
since it's too lazy implementation... :pray:
@tbrand We can also call clean
implicitly. While the results computation will be stabilized, I'll plan to clean the build process (avoid to have 1 Dockerfile
per project, but 1 but language
)
@waghanza I can work on it. Could you open the PR from the origin branch? (not forked one.) Then I can push the patches on it.
done in #186
I can work on it.
I mean I can work on avoiding the lazy implementation in Dockerfile. (Not for the clean
action.)
Ok, anyway, I'll push patches for it. Please wait for it.
Let me close this PR since I've push the patches at https://github.com/tbrand/which_is_the_fastest/pull/187
If you have more patches, please push directly on #187 Thanks for the great works!
Hi,
This
PR
run all frameworks intodocker
containers.In order to build and run :
@tbrand I have disabled
crillo
, since only onOS X
.Regards,