search

the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.91k stars 641 forks source link

F# Frameworks #2874

Closed panesofglass closed 3 years ago

panesofglass commented 3 years ago

Closes #2869

pimbrouwers commented 3 years ago

The Falco code looks perfect. Thank you for doing this Ryan!

panesofglass commented 3 years ago

@waghanza, looks like it doesn’t like the sorbet publish command. I’ll look into it.

panesofglass commented 3 years ago

It seems the WebSharper build only works out of the box on netcoreapp2.1. I'll comment this one out for now and let @granicz or @Tarmil submit a fix.

pimbrouwers commented 3 years ago

Great work Ryan! Looking forward to seeing the results!

panesofglass commented 3 years ago

@waghanza any idea why the git pull failed on the Travis builds? Is this due to some sort of request throttling? Any chance you can re-run the build?

waghanza commented 3 years ago

@panesofglass Sometimes, it happens ... seems that a network issue or git was ammended, btw, I've restarted (PS : In the next version we will use https://the-benchmarker.semaphoreci.com/projects/web-frameworks)

@pimbrouwers Is there any stable release of Falco ?

waghanza commented 3 years ago

failed at https://travis-ci.com/github/the-benchmarker/web-frameworks/jobs/344675833#L399 @panesofglass @Tarmil any idea ?

pimbrouwers commented 3 years ago

@waghanza The latest alpha build is stable and should be officially released shortly. There won't be any core code changes during the release. Only improved testing. The current version is ready for production.

waghanza commented 3 years ago

Ok, then I'll merge this time, when someone with F# skill could fix CI

However, I prefer NOT to include in this list any version not labelled as stable :stuck_out_tongue:

pimbrouwers commented 3 years ago

@waghanza can you wait an hour or so? My plan was to release this weekend. So I can just expedite?

waghanza commented 3 years ago

sure ... In fact, I think, it will take time to fix CI :stuck_out_tongue:

but, I'll wait until you release, at least this project is also to promote OSS :heart: and I prefer to promote anything stable :+1:

pimbrouwers commented 3 years ago

No problem. Makes sense. I'll do my best to get it done today.

waghanza commented 3 years ago

No hurry @pimbrouwers, I'll promote mostly after https://github.com/the-benchmarker/web-frameworks/pull/2593#partial-pull-merging is finished, cause this will run on cloud infrastructure => https://digitalocean.com

pimbrouwers commented 3 years ago

Ok! v1.1.0 has been deployed to nuget. @panesofglass do you mind changing the package version to 1.1.0 in the proj file? Or would you rather I submit a PR on your PR?

panesofglass commented 3 years ago

@waghanza WebSharper has a known issue running when targeting netcoreapp3.1 on docker. Should I pull that to another branch to track separately?

panesofglass commented 3 years ago

@pimbrouwers Done!

@waghanza I took websharper out of the build list. That should get this to pass. We can add it again when they have it fixed. See https://github.com/dotnet-websharper/core/issues/1044#issuecomment-639575833

pimbrouwers commented 3 years ago

Thanks Ryan! I submitted a PR as well. But shouldn't be a game changer, so feel free to ignore. If we can roll it in though, great!

pimbrouwers commented 3 years ago

I submitted a PR to Ryan's repo that will take care of the yaml file. I'm not a fan of floating versions. But if you'd rather have the wildcard in there, that's fine too.

On Sat., Jun. 6, 2020, 11:53 a.m. Marwan Rabbâa, notifications@github.com wrote:

@waghanza requested changes on this pull request.

In fsharp/falco/config.yaml https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278399 :

@@ -0,0 +1,3 @@ +framework:

  • website: github.com/pimbrouwers/Falco
  • version: 1.0.10-alpha

You forget to update this. Moreover, I prefer having X.Y format -> 1.1

In fsharp/frank/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278744 :

@@ -0,0 +1,11 @@ +

  • netcoreapp3.1

It's better to use 6.0. to have 6.0.x*

In fsharp/falco/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278783 :

@@ -0,0 +1,11 @@ +

  • netcoreapp3.1

It's better to use 1.1. to have 1.1.x*

In fsharp/websharper/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278931 :

@@ -0,0 +1,21 @@ + +

  • netcoreapp3.1
  • Website
  • $(MSBuildThisFileDirectory)/wwwroot

It's better to use 4.6. to have 4.6.x*

In fsharp/websharper/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278984 :

+ +

  • netcoreapp3.1
  • Website
  • $(MSBuildThisFileDirectory)/wwwroot

It's better to use 4.6. to have 4.6.x*

In fsharp/websharper/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436278996 :

+

  • netcoreapp3.1
  • Website
  • $(MSBuildThisFileDirectory)/wwwroot

It's better to use 4.6. to have 4.6.x*

In fsharp/websharper/web.fsproj https://github.com/the-benchmarker/web-frameworks/pull/2874#discussion_r436279002 :

  • netcoreapp3.1
  • Website
  • $(MSBuildThisFileDirectory)/wwwroot

It's better to use 4.6. to have 4.6.x*

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/the-benchmarker/web-frameworks/pull/2874#pullrequestreview-425749099, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDB57N4G6S3CAHVVZS7S3TRVJQ6NANCNFSM4NTEU6EQ .

waghanza commented 3 years ago

@pimbrouwers I do not know if there is an other way in F# to define a version range

panesofglass commented 3 years ago

I don't suppose I need to worry about the AnyLint failure? I've never even heard of that plugin before.

waghanza commented 3 years ago

Nop, it's good. AnyLint complains about markdown, I'll disable it (since it will README.md will be completely rewritten)

panesofglass commented 3 years ago

@waghanza looks like the last build had the same issue with pulling and merging the branch. :( Any chance you could kick off another?

waghanza commented 3 years ago

sure. I'll test locally, generate some result, and push again, this will trigger CI again. I'm having more and more build problems with actual CI

waghanza commented 3 years ago

I suppose the CI fails because of some merge strategy (we are using squash) different in your repo @panesofglass (github's default is to create a merge commit)

pimbrouwers commented 3 years ago

Shouldn't these be appearing in the results? It says they were update 2020/06/06.

waghanza commented 3 years ago

The results are updated in https://github.com/panesofglass/web-frameworks/tree/fsharp/frank#results, the process is still manual, and takes a long long time

waghanza commented 3 years ago

@panesofglass @pimbrouwers @dustinmoris As to have a professional benchmark, I would like to add you as codeowners (of the framework you make / contribute to). Do you consent on such a thing ?

dustinmoris commented 3 years ago

Fine with me! Thanks