Add Kore (#224) - Githubissues

the-benchmarker / web-frameworks

Which is the fastest web framework?

MIT License

6.91k stars 641 forks source link

Add Kore (#224) #430

Closed zhangkaizhao closed 5 years ago

zhangkaizhao commented 5 years ago

Use nginx rewrite module to support /user/:id path because this feature is still not supported so far (latest version: 3.1.0 at the moment)

OvermindDL1 commented 5 years ago

Use nginx rewrite module to support /user/:id path because this feature is still not supported so far

Elaborate?

zhangkaizhao commented 5 years ago

Use nginx rewrite module to support /user/:id path because this feature is still not supported so far

Elaborate?

Please take a look at the replies in the reviews.

OvermindDL1 commented 5 years ago

Use nginx rewrite module to support /user/:id path because this feature is still not supported so far

Elaborate?

Please take a look at the replies in the reviews.

And my reply there as well. ^.^

waghanza commented 5 years ago

^^

I always enjoyed your straight talk @OvermindDL1

OvermindDL1 commented 5 years ago

I always enjoyed your straight talk

Lol, what do I do? ^.^;

waghanza commented 5 years ago

nothing, I like it

you have opinions, you say it direct (some people could take it hard), but its ok

OvermindDL1 commented 5 years ago

(some people could take it hard)

I would never intend so! I do some teaching in real life so I have to be quick, direct, and comprehensive there, so it's mostly become how I talk anymore... ^.^;

waghanza commented 5 years ago

Sure, do not worry about that. It is just very different that what I use to know 😎

zhangkaizhao commented 5 years ago

@OvermindDL1 Thanks for the review and guidance. I will try it later.

waghanza commented 5 years ago

@zhangkaizhao Thanks for your contribution, I flag this PR as pending until your update :heart:

zhangkaizhao commented 5 years ago

Found the explanation of dynamic handler in: https://github.com/jorisvink/kore/blob/3.1.0-release/conf/kore.conf.example#L243 and exact example in: https://github.com/jorisvink/kore/blob/3.1.0-release/examples/video_stream/conf/video_stream.conf#L16 . I need to read more source code to find out how to get the :id from path with regex. Working on it...

OvermindDL1 commented 5 years ago

Ah nice shrinking!

waghanza commented 5 years ago

@OvermindDL1 is this PR ok for you ?

xieyuheng commented 5 years ago

The issue has been there for uncomfortably long time for me. Please merge this PR ! If something went wrong, we fix it with new PR

waghanza commented 5 years ago

@xieyuheng please, be nice. As you know opensource is done in spare time, no need to be aggressive to solve anything

xieyuheng commented 5 years ago

@waghanza If my three lines above reads aggressive to you, I apologize. I hope merging PR quickly will make people feel happy and involved.

waghanza commented 5 years ago

do not worry @xieyuheng, this PR will be valued in time, waiting for @OvermindDL1 approval

(I'm a ruby guy not C one :stuck_out_tongue_winking_eye: )

OvermindDL1 commented 5 years ago

It looks good to me now! I like it! :-)

waghanza commented 5 years ago

@OvermindDL1 @zhangkaizhao I've updated results https://github.com/the-benchmarker/web-frameworks#full-table

zhangkaizhao commented 5 years ago

@waghanza Well done! :clap: :tada: :sparkles:

waghanza commented 5 years ago

@zhangkaizhao in which version of C this is compiled ?