the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.91k stars 641 forks source link

Please add the libhv library #5573

Open leamus opened 1 year ago

leamus commented 1 year ago

Please add the libhv library, which is also a very good and few C/C++ Library: https://github.com/ithewei/libhv

waghanza commented 1 year ago

Hello,

Thanks for proposal. Any PR is gladly welcome.

However, we require explicit consent from author of any framework in here, or any active contributor (without any disapproval in 10 days we consider that consent is given).


Did you consent to add libhv in here @ithewei ?


This project compare performance based on 3 routes :

Regards,

leamus commented 1 year ago

Yes, I agree very much

waghanza commented 1 year ago

Any PR is welcome then, and will be quickly reviewed

jamesli2021 commented 1 year ago

Does a network library categories as web framework?

waghanza commented 1 year ago

It could, imho. A library is a piece of consistent toolset used to build a bigger app.

For example, you can avoid using expressjs, and use pure node to build your app / service

leamus commented 1 year ago

Hello, has libhv been added to the project?

waghanza commented 1 year ago

Not all all. Glad to receive any PR

leamus commented 1 year ago

Can you tell me when to add?

waghanza commented 1 year ago

You need to implement of https://github.com/the-benchmarker/web-frameworks/issues/5573#issuecomment-1227272960 in cpp folder

jamesli2021 commented 1 year ago

@waghanza @leamus isn't the author of the libhv, and the author have not express his interest to participate in the benchmark.

Anyway, my personal benchmark found libhv is on par with Go Echo, Gin, Chi.

waghanza commented 1 year ago

@jamesli2021 who is the author then ?

if any core contributor is opposed to include libhv here, we shall respect this choice

leamus commented 1 year ago

The author is HeWei. He asked me to apply for the test here, but I didn't know how to do it, so I asked here

waghanza commented 1 year ago

just create a basic project that implement 3 endpoints (described above) :-)

leamus commented 1 year ago

Thanks, I'll try

leamus commented 1 year ago

I have finished the example project. How can I upload it?

waghanza commented 1 year ago

Make a PR in this project ❤️

jamesli2021 commented 1 year ago

Maybe if you have problem with how to create PR, I suggest you could zip the source code and reply here.

waghanza commented 1 year ago

or send me by email @leamus

leamus commented 1 year ago

I have successfully created the PR, but I am not very good at using CMake (I often use qmake). If you can help me to modify it, thank you very much. https://github.com/the-benchmarker/web-frameworks/actions/runs/3238749453

----- 原始邮件 ----- 发件人:jamesli2021 @.> 收件人:the-benchmarker/web-frameworks @.> 抄送人:深林孤鹰 @.>, Mention @.> 主题:Re: [the-benchmarker/web-frameworks] Please add the libhv library (Issue #5573) 日期:2022年10月14日 21点47分

Maybe if you have problem with how to create PR, I suggest you could zip the source code and reply here.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

waghanza commented 1 year ago

I am not sure qmake is the standard way to compile C++ but anyway, feel free to push any qmake and write here some instruction about how to compile it 😛

leamus commented 1 year ago

qmake is the construction tool of Qt, and it is no longer updated, so don't worry about it~😛 ----- 原始邮件 ----- 发件人:Marwan Rabbâa @.> 收件人:the-benchmarker/web-frameworks @.> 抄送人:深林孤鹰 @.>, Mention @.> 主题:Re: [the-benchmarker/web-frameworks] Please add the libhv library (Issue #5573) 日期:2022年10月15日 16点54分

I am not sure qmake is the standard way to compile C++ but anyway, feel free to push any qmake and write here some instruction about how to compile it 😛

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>