[JavaScript] Add Astro - Githubissues

the-benchmarker / web-frameworks

Which is the fastest web framework?

MIT License

6.91k stars 641 forks source link

[JavaScript] Add Astro #6029

Closed RoadRoller01 closed 2 weeks ago

RoadRoller01 commented 1 year ago

Astro website

RoadRoller01 commented 1 year ago

Hi @RoadRoller01,

Feel free to open a PR then ❤️

We (mostly me) could take care of any implementation in here.

If you want to make a PR, you should implement Astro (in javascript folder) with the following :

GET /, SHOULD return a successful status code and an empty string
GET /user/:id, SHOULD return a successful status code and the id
POST /user, SHOULD return a successful status code and an empty string

Regards,

@waghanza you were late by two steps

waghanza commented 1 year ago

You answered your own issue @RoadRoller01 😛 anyway thanks for your interest in this project

As you say, feel free to open a PR, I'll review it

Btw, to include it here you will ne explicit approval from any core contributor (cc @FredKSchott @matthewp @natemoo-re) or wait for 10 days if no answer (and no opposition to include astro here)

Regards,

ghost commented 1 year ago

How about rebuiling benchmark results chart with Astro and add to showcase instead? It's exactly what Astro is designed for, start with 0KB of JavaScript. https://astro.build/showcase/

waghanza commented 1 year ago

Not sure it is the same subject @RoadRoller01. The website charts are built on https://github.com/the-benchmarker/website but @SuspiciousLookingOwl is working on it, feel free to join forces ❤️

But maybe benchmarking api with astro is an other topic

RoadRoller01 commented 2 weeks ago

aaa i think i will close this issue, i lost the interest to astro.