the-benchmarker / web-frameworks

Which is the fastest web framework?
MIT License
6.91k stars 641 forks source link

Change startup commands for bun and deno #6531

Closed jim-king-2000 closed 9 months ago

jim-king-2000 commented 10 months ago

See elysiajs/elysia#64.

jim-king-2000 commented 10 months ago

pm2 is not installed in containers.

Change it to pm2-runtime.

You will need to add {{#deps}} RUN apk add {{{.}}} {{/deps}}

{{#bootstrap}} RUN {{{.}}} {{/bootstrap}}

after WORKDIR in deno.Dockerfile

Done.

and bun install prior to CMD in bun.Dockerfile

Done.

jim-king-2000 commented 10 months ago

Still some errors. Any solution?

jim-king-2000 commented 10 months ago

This error:

curl --retry 5 --retry-delay 5 --retry-max-time 180 --retry-connrefused http://`cat javascript/elysia/ip-bun.txt`:3000 -v
* Closing connection -1

It seems that the ip address is not acquired.

jim-king-2000 commented 10 months ago

Still not OK. The same issue.

jim-king-2000 commented 10 months ago

Good for bun, but deno still fails.

jim-king-2000 commented 10 months ago

Accroding to the bun startup command, I modify the deno startup command as the following: nohup pm2-runtime start "deno run --allow-net --allow-read=. app.ts" -i max Thank god, it works.

jim-king-2000 commented 10 months ago

What's wrong withstricjs?

waghanza commented 10 months ago

I don't know. Any request is failing

Stack is

1 |
2 | const c0=app.static['/']['GET'],c1=app.static['/user']['POST'],f=app.router.find.bind(app.router);return function(r){const s=url.indexOf('/',12) + 1;r.query=r.url.indexOf('?',s);const p=r.query===-1?r.url.substring(s):r.url.substring(s,r.query);switch(p){case'':if(r.method==='GET')return c0(r);break;case'user':if(r.method==='POST')return c1(r);break;}const o=f(r.method,p);if(o===null)return;r.params=o;return o._(r);}
                                                                                                                                                                                                                                                 ^
ReferenceError: Can't find variable: url

cc @aquapi

jim-king-2000 commented 10 months ago

Shall we fix the failure of stricjs?

waghanza commented 10 months ago

We can try either in this PR or in another, stricjs I'd already failing on master so both solutions are OK for me.

However, since I cannot publish the results this monday, we can wait a little bit to handle a fix.

jim-king-2000 commented 9 months ago

OK. I'm going to fix stricjs.

jim-king-2000 commented 9 months ago

The case of low-http-server failed. I didn't touch it. So I think this PR is ready to be merged.

waghanza commented 9 months ago

Could you merge master please ? @jim-king-2000

jim-king-2000 commented 9 months ago

Could you merge master please ? @jim-king-2000

Done.

jim-king-2000 commented 9 months ago

I'm looking forward to the result.

waghanza commented 9 months ago

Will be done next monday

jim-king-2000 commented 9 months ago

Will be done next monday

Could be a little bit earlier?

waghanza commented 9 months ago

I can understand the impatience, but no reasons to rush

I prefer to keep the same publishing day (except that I can not this one)

jim-king-2000 commented 9 months ago

Sure. Take your time.

By the way, I'm just destroyed by this book.

jim-king-2000 commented 9 months ago

Will be done next monday

No new result? @waghanza

waghanza commented 9 months ago

Something went wrong on my end. Will publish results next week (and ping you)

cyrusmsk commented 9 months ago

I hope that it was not my D PRs) looking forward results next week :) thanks @waghanza

jim-king-2000 commented 9 months ago

Something went wrong on my end. Will publish results next week (and ping you)

Just a kind reminder, "next week" is coming.

waghanza commented 9 months ago

don't worry, it's planned :-)