search

the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
78 stars 35 forks source link

"Upcoming match" notification text should be revised #583

Closed nwalters512 closed 8 years ago

nwalters512 commented 8 years ago

Currently reads something like "Match SCMB Q7", should really be "SCMB Match Q7". While we're at it, we should check all the notification text to make sure it looks good.

1fish2 commented 8 years ago

I forgot if I wrote it that way to fix the ambiguity (Q7 at which event?) across the board with minimum risk during competition season or to make the messages structured (logically, the full event name is 2016-SCMB-Q7; obviously the year matters for historical stats but not for notifications).

Hypothesis: Many of the people who use notifications receive multiple notification types about multiple teams at multiple events during a weekend and sometimes watch simultaneous webcasts via the GameDay page. They need notifications that are unambiguous, concise (one-line messages don't get collapsed), and not taxing to understand while busy watching 1-3 webcasts. Not all of us are great multitaskers. Simple templates are easier to parse than English prose.

Usability testing could validate or disprove this or compare alternate phrasing. E.g. use the Python script to show example messages to a few people from the target audience while they watch recorded match videos. Can they figure out a message the first viewing and quickly understand it in repeat viewings?

I'm fine with the suggestion, i.e. "Starting soon: SCMB match Q7" but will all the event names and notification types fit on a line? How about "Starting soon: SCMB-Q7"?

Notifications like "Teams 111, 222, and 3333 scored 176 vs. 444, 555, and 6666 scored 88" would benefit greatly from bolding the team numbers that you're following. Is bold achievable in a notification? On Feb 26, 2016 5:06 PM, "Nathan Walters" notifications@github.com wrote:

Currently reads something like "Match SCMB Q7", should really be "SCMB Match Q7". While we're at it, we should check all the notification text to make sure it looks good.

— Reply to this email directly or view it on GitHub https://github.com/the-blue-alliance/the-blue-alliance-android/issues/583 .

nwalters512 commented 8 years ago

I'd be in favor of your suggestion "Starting soon: SCMB-Q7". Most people should understand that means a match is starting soon, so labeling it explicitly as a match is probably unnecessary. It would be nice to do user testing with a few of these variants though.

It looks like we have limited control over how notification text is styles, so bolding should be possible: http://stackoverflow.com/questions/23917127/how-to-highlight-left-hand-side-text-of-every-line-in-notification

1fish2 commented 8 years ago

Cool. I can probably get on it this weekend. If someone else wants to do it before then, just call dibs. On Feb 29, 2016 6:34 PM, "Nathan Walters" notifications@github.com wrote:

I'd be in favor of your suggestion "Starting soon: SCMB-Q7". Most people should understand that means a match is starting soon, so labeling it explicitly as a match is probably unnecessary. It would be nice to do user testing with a few of these variants though.

It looks like we have limited control over how notification text is styles, so bolding should be possible: http://stackoverflow.com/questions/23917127/how-to-highlight-left-hand-side-text-of-every-line-in-notification

— Reply to this email directly or view it on GitHub https://github.com/the-blue-alliance/the-blue-alliance-android/issues/583#issuecomment-190279606 .

phil-lopreiato commented 8 years ago

Ideally we can ship a fix for week 1 events, that release will have to be Wednesday night at the latest.

@1fish2 is that too soon for you?

1fish2 commented 8 years ago

Yes, alas, I can't get to it before this weekend.

phil-lopreiato commented 8 years ago

Ah, I see.

I can make the quick change to "Starting soon: SCMB-Q7" for this week to clear up the initial ambiguity. Can you still take a look at bolding followed teams (probably just have to @Inject SubscriptionsTable) and/or some other improvements?

1fish2 commented 8 years ago

Yes. Let's split out the changes for next week into a separate issue, and I'll take that one.

I haven't looked at the code base since the redesign. Can you point me to docs on the dependency injection and other changes?

phil-lopreiato commented 8 years ago

We use dagger2 for dependency injection, it's a really cool premise.

You'll probably want to change the signature of buildNotification to also take an instance of the database table. Then you could inject it into GcmMessageHandler pass it to the other method.