the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
78 stars 35 forks source link

This event IS part of a district #821

Open 1fish2 opened 7 years ago

1fish2 commented 7 years ago

The ⓘ at the bottom of this screen is wrong. This event is part of a district.

part of a district

TBA Web has it straight.

phil-lopreiato commented 7 years ago

Can you check again? I can't get a repro...

device-2017-03-07-132454

1fish2 commented 7 years ago

That banner is still showing for me, also after tapping the Refresh button, and after backing out of the app and coming back.

Should I try uninstalling & reinstalling it? Maybe there's some state here useful for debugging?

Also weird: Mine shows Rank 7 FRC6350 with the name "The Enumclaw Hornets" while yours shows "The Ratcheteers"! TBA Web agrees with my Android app on the team name.

[Also -- a separate bug but I need to jet -- TBA Web shows FRC6350 and FRC4450 in the other order, rank 6 and 7 respectively, both with 42 points. The ranking should ought to be consistent.]

Logcat entries in case they help:

03-07 10:31:39.177  9528  9528 W GAv4    : Discarding hit. Missing tracking id parameter: a=1820439457,an=The Blue Alliance,t=screenview,cd=com.thebluealliance.androidclient.activities.HomeActivity,sf=100.0,aid=4.0.2,av=4.0.2
03-07 10:31:39.182  9528  9528 E SQLiteLog: (5) statement aborts at 2: [PRAGMA journal_mode=PERSIST]
03-07 10:31:39.182  9528  9528 W SQLiteConnection: Could not change the database journal mode of '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' from 'wal' to 'PERSIST' because the database is locked.  This usually means that there are other open connections to the database which prevents the database from enabling or disabling write-ahead logging mode.  Proceeding without changing the journal mode.
03-07 10:31:39.193  9528  9528 W com.thebluealliance.androidclient.activities.NavigationDrawerActivity: No current user found
03-07 10:31:39.201  9528 10868 I android.app.IntentService$ServiceHandler: Trying to migrate legacy auth to Firebase
03-07 10:31:39.201  9528 10868 I com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Lazy loading Google API Client for legacy sign in
03-07 10:31:39.286  5050  5106 I ActivityManager: Displayed com.thebluealliance.androidclient/.activities.HomeActivity: +150ms (total +188ms)

...

03-07 10:31:39.534  8025 18624 W Auth    : [GetToken] GetToken failed with status code: NeedPermission
03-07 10:31:39.544  8408 26631 W Auth    : [GoogleAuthUtil] GoogleAuthUtil
03-07 10:31:39.547  9528 10868 W com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Unable to complete legacy sign in: null
03-07 10:31:39.547  9528 10868 I android.app.IntentService$ServiceHandler: Failed to migrate
03-07 10:31:39.548  9528 10868 I android.app.IntentService$ServiceHandler: Trying to migrate legacy auth to Firebase
03-07 10:31:39.697  8025 29587 W Auth    : [GetToken] GetToken failed with status code: NeedPermission
03-07 10:31:39.718  8408 26631 W Auth    : [GoogleAuthUtil] GoogleAuthUtil
03-07 10:31:39.721  9528 10868 W com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Unable to complete legacy sign in: null
03-07 10:31:39.721  9528 10868 I android.app.IntentService$ServiceHandler: Failed to migrate
03-07 10:31:39.919 13827 14027 W SearchService: Abort, client detached.

...

03-07 10:31:41.285  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:41.286  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:41.286  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:41.287  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:42.850  5050 18693 I ActivityManager: START u0 {cmp=com.thebluealliance.androidclient/.activities.ViewEventActivity (has extras)} from uid 10088 on display 0
03-07 10:31:42.902  9528  9528 W android.support.v4.app.Fragment: No current user found
03-07 10:31:42.907  9528  9528 I AppCompatViewInflater: app:theme is now deprecated. Please move to using android:theme instead.
03-07 10:31:42.913  9528  9528 I AppCompatViewInflater: app:theme is now deprecated. Please move to using android:theme instead.
03-07 10:31:42.923  9528  9528 E SQLiteLog: (5) statement aborts at 2: [PRAGMA journal_mode=PERSIST]
03-07 10:31:42.923  9528  9528 W SQLiteConnection: Could not change the database journal mode of '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' from 'wal' to 'PERSIST' because the database is locked.  This usually means that there are other open connections to the database which prevents the database from enabling or disabling write-ahead logging mode.  Proceeding without changing the journal mode.
03-07 10:31:42.931  9528  9528 W GAv4    : Discarding hit. Missing tracking id parameter: a=1820439457,an=The Blue Alliance,t=screenview,cd=com.thebluealliance.androidclient.activities.ViewEventActivity,sf=100.0,aid=4.0.2,av=4.0.2
03-07 10:31:42.936  9528  9528 W com.thebluealliance.androidclient.activities.NavigationDrawerActivity: No current user found
03-07 10:31:42.945  9528  9528 E SQLiteLog: (5) statement aborts at 2: [PRAGMA journal_mode=PERSIST]
03-07 10:31:42.946  9528  9528 W SQLiteConnection: Could not change the database journal mode of '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' from 'wal' to 'PERSIST' because the database is locked.  This usually means that there are other open connections to the database which prevents the database from enabling or disabling write-ahead logging mode.  Proceeding without changing the journal mode.
03-07 10:31:43.048  9528  9528 E RecyclerView: No adapter attached; skipping layout
03-07 10:31:43.048  9528  9528 E RecyclerView: No adapter attached; skipping layout
03-07 10:31:43.098  9528 10881 I android.app.IntentService$ServiceHandler: Trying to migrate legacy auth to Firebase
03-07 10:31:43.098  9528 10881 I com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Lazy loading Google API Client for legacy sign in
03-07 10:31:43.141  5050  5106 I ActivityManager: Displayed com.thebluealliance.androidclient/.activities.ViewEventActivity: +274ms
03-07 10:31:43.166  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.167  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.167  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.168  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.169  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.170  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.170  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.171  9528  9536 W SQLiteConnectionPool: A SQLiteConnection object for database '/data/user/0/com.thebluealliance.androidclient/databases/the-blue-alliance-android-database' was leaked!  Please fix your application to end transactions in progress properly and to close the database when it is no longer needed.
03-07 10:31:43.368  9528  9576 D OpenGLRenderer: endAllActiveAnimators on 0x6f9823b400 (RippleDrawable) with handle 0x6f95707580
03-07 10:31:43.422  8025 17743 W Conscrypt: Could not set socket write timeout: null
03-07 10:31:43.440  8025 17743 W Conscrypt: Could not set socket write timeout: null
03-07 10:31:43.543   401   401 W SurfaceFlinger: couldn't log to binary event log: overflow.
03-07 10:31:43.575  8025 17743 W Auth    : [GetToken] GetToken failed with status code: NeedPermission
03-07 10:31:43.595  8408 26631 W Auth    : [GoogleAuthUtil] GoogleAuthUtil
03-07 10:31:43.599  9528 10881 W com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Unable to complete legacy sign in: null
03-07 10:31:43.599  9528 10881 I android.app.IntentService$ServiceHandler: Failed to migrate
03-07 10:31:43.600  9528 10881 I android.app.IntentService$ServiceHandler: Trying to migrate legacy auth to Firebase
03-07 10:31:43.729  8025 29786 W Auth    : [GetToken] GetToken failed with status code: NeedPermission
03-07 10:31:43.752  8408 26631 W Auth    : [GoogleAuthUtil] GoogleAuthUtil
03-07 10:31:43.757  9528 10881 W com.thebluealliance.androidclient.auth.firebase.FirebaseAuthProvider: Unable to complete legacy sign in: null
phil-lopreiato commented 7 years ago

I'd just keep an eye out for it again this week, and I'll try and see what's up while the event is live

1fish2 commented 7 years ago

Does the app on your phone have some broken data cached? Why does it name FRC6350 "The Ratcheteers"? TBA Web lists no such team name.

(The first screenshot was mid-event, so never mind discrepancies with the second screenshot.)

1fish2 commented 7 years ago

The problem is not repeating today for any district events that I checked: Week 1 Auburn MV, West Valley; Week 2 Ann Arbor, Mount Olive, Hafia; Week 3 Boston, Mount Vernon, Columbus.

We could close it, esp. if there's a reason to bet that a change fixed it.

1fish2 commented 7 years ago

The symptom is back today for the Mount Vernon district event.

Also in the list of Week 3 events, Mount Vernon is listed under "District Events" rather than "Pacific Northwest District Events".

phil-lopreiato commented 7 years ago

Yay intermittent issues... Can you look in stetho at the db and see if that event has anything in the district key column?

1fish2 commented 7 years ago

The debug build is not currently exhibiting the symptom. It's listing Mount Vernon under PNW District Events and not showing the "not part of a district" sub-banner.

Stetho's view of the events table shows the 2017wamou event with district_key = 2017pnw. The eventDetails table has an entry for 2017wamou_districtPoints.

Any ideas on how to trigger the intermittent issue? I'll tinker a bit then head to SF to watch the playoffs live.

phil-lopreiato commented 7 years ago

I have no idea how to trigger it, unfortunately. My theory is that either the district_key field in events or the row in the districts table aren't getting properly filled. But it's going to be hard to confirm that until one of us can see it on a debug build.

1fish2 commented 7 years ago

How about adding some logging for that to the release build?

What would it take in the code for an event to appear under generic "District Events"?

phil-lopreiato commented 7 years ago

Good call, that shouldn't be too hard. I'd have to look at the code to see the exact case, although EventListSubscriber is the place to start