the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

Add Media tab to Team at Event #882

Closed gregmarra closed 5 years ago

gregmarra commented 5 years ago

Summary:

Adds Media to the TeamAtEvent pages

Issues Reference:

Per #863, we know people use the Team @ Event pages much more than Team pages, so we should make sure the most useful information is displayed there. Indexing robot photos is a unique feature of TBA, so this adds the Media tab to the Team @ Event views.

Test Plan:

Look at Team 254 @ Arizona 2018 . Observe a Media tab that matches the Team 254 2018 Media tab renders, although no media renders.

I am not sure why no media is rendering locally, either for imgur photos or for youtube videos. I tested with Team 254's 2018 data, which has 2 imgur, 1 instagram, and 1 youtube media. https://www.thebluealliance.com/team/254/2018 . These media also fail to render in master on the the Team Media tab, so the problem seems unrelated to my changes.

31 tests fail, and I am not sure whether they are related to these changes.

Screenshots:

Team 254 Media: screenshot_1546354674

Before: screenshot_1546354862

After: screenshot_1546354664

phil-lopreiato commented 5 years ago

Travis should be fixed on master now - can you rebase?

(other than that, this LGTM)

phil-lopreiato commented 5 years ago

And the blank image thing should be fixed in https://github.com/the-blue-alliance/the-blue-alliance-android/commit/3ee07c44c3077a7a1b792b26c9f13704f2af368b

gregmarra commented 5 years ago

After rebasing, photos are displaying correctly.

screenshot_1546371318