Closed gregmarra closed 5 years ago
Travis should be fixed on master now - can you rebase?
(other than that, this LGTM)
And the blank image thing should be fixed in https://github.com/the-blue-alliance/the-blue-alliance-android/commit/3ee07c44c3077a7a1b792b26c9f13704f2af368b
After rebasing, photos are displaying correctly.
Summary:
Adds Media to the TeamAtEvent pages
Issues Reference:
Per #863, we know people use the Team @ Event pages much more than Team pages, so we should make sure the most useful information is displayed there. Indexing robot photos is a unique feature of TBA, so this adds the Media tab to the Team @ Event views.
Test Plan:
Look at Team 254 @ Arizona 2018 . Observe a Media tab that matches the Team 254 2018 Media tab renders, although no media renders.
I am not sure why no media is rendering locally, either for imgur photos or for youtube videos. I tested with Team 254's 2018 data, which has 2 imgur, 1 instagram, and 1 youtube media. https://www.thebluealliance.com/team/254/2018 . These media also fail to render in master on the the Team Media tab, so the problem seems unrelated to my changes.
31 tests fail, and I am not sure whether they are related to these changes.
Screenshots:
Team 254 Media:![screenshot_1546354674](https://user-images.githubusercontent.com/57101/50574017-1e474000-0dad-11e9-9951-1bdc86751d07.png)
Before:![screenshot_1546354862](https://user-images.githubusercontent.com/57101/50574012-125b7e00-0dad-11e9-9a1d-0b890b4be2be.png)
After:![screenshot_1546354664](https://user-images.githubusercontent.com/57101/50574016-19828c00-0dad-11e9-9cec-167a46057965.png)