the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

Team@Event is blank for unplayed events #886

Closed phil-lopreiato closed 5 years ago

phil-lopreiato commented 5 years ago

This is a terrible experience.

Way to fix this: TeamAtEventSummaryFragment needs to load the event info as well and add an observable combiner thing to create a composite data model of the Event and TeamAtEventStatus.

And then if the event comes back as unplayed, generate a placeholder item in TeamAtEventSummarySubscriber.

Currently, the subscriber just reads the event out of the local db, but if the event is unplayed, it never gets to this point. Instead, we can actually hit the API for the event (and that way it'll work better if the event happens to not be loaded) and use that result instead

Existing code examples/references: