the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

Fix crash on ContributorsActivity load #891

Closed EthShaw closed 5 years ago

EthShaw commented 5 years ago

Summary: When I tried to open the contributors page in the settings tab, the app crashed and restarted. I experimented with this further and came to the conclusion that it was throwing an IllegalStateException because the AuthModule was not set. I believe that ContributorsActivity.getComponent() was not updated to reflect the changes in PR #884, causing the crash. When I added .authModule(application.getAuthModule()) to the DaggerFragmentComponent builder in ContributorsActivity.java, it fixed the crash.

Test Plan: Manual test.