the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
78 stars 35 forks source link

Feature Request: Adaptive Icon #912

Closed gregmarra closed 5 years ago

gregmarra commented 5 years ago

https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive

This will make our icon render better on more Android launchers.

bherbst commented 5 years ago

I've actually been working on this and soonest have it in a good place, just need to get a better SVG of the logo. The one on GitHub has some weird gaps.

On Sun, Mar 24, 2019, 11:31 AM Greg Marra notifications@github.com wrote:

https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive

This will make our icon render better on more Android launchers.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/the-blue-alliance/the-blue-alliance-android/issues/912, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHdVchMfnWta8qdNsmO1dxpvND6ITI4ks5vZ6hYgaJpZM4cFmVN .

gregmarra commented 5 years ago

Awesome! What are the issues with the logo on GitHub?

On Sun, Mar 24, 2019 at 6:04 PM Bryan Herbst notifications@github.com wrote:

I've actually been working on this and soonest have it in a good place, just need to get a better SVG of the logo. The one on GitHub has some weird gaps.

On Sun, Mar 24, 2019, 11:31 AM Greg Marra notifications@github.com wrote:

https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive

This will make our icon render better on more Android launchers.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/the-blue-alliance/the-blue-alliance-android/issues/912 , or mute the thread < https://github.com/notifications/unsubscribe-auth/ADHdVchMfnWta8qdNsmO1dxpvND6ITI4ks5vZ6hYgaJpZM4cFmVN

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-blue-alliance/the-blue-alliance-android/issues/912#issuecomment-476005124, or mute the thread https://github.com/notifications/unsubscribe-auth/AADfDex4X3GQMPgzn0zByBco_71_-CZzks5vZ_ZYgaJpZM4cFmVN .

bherbst commented 5 years ago

I'm not sure if this will come through properly (on my phone right now), but there are gaps at the bottom, right at the transition between the vertical side lines and the bottom half circle. They become particularly prominent when I use that as the foreground in an adaptive icon.

content://com google android googlequicksearchbox CommonContentProvider/assist com google android apps gsa staticplugins assist screenshot ScreenshotProvider/com google android apps gsa staticplugins assist screenshot ScreenshotProvider/ScreenAssistScreenshots/Screenshot_20190324-174609

gregmarra commented 5 years ago

Oh hmm! Perhaps we can get someone to fix it, or you might be able to edit it as part of this.

On Sun, Mar 24, 2019 at 6:49 PM Bryan Herbst notifications@github.com wrote:

I'm not sure if this will come through properly (on my phone right now), but there are gaps at the bottom right at three transition between the vertical side lines and the bottom half circle. They become particularly prominent in the icon.

[image: content://com google android googlequicksearchbox CommonContentProvider/assist com google android apps gsa staticplugins assist screenshot ScreenshotProvider/com google android apps gsa staticplugins assist screenshot ScreenshotProvider/ScreenAssistScreenshots/Screenshot_20190324-174609] https://user-images.githubusercontent.com/3267925/54887073-e7893f00-4e5c-11e9-9806-3176fdc20a29.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-blue-alliance/the-blue-alliance-android/issues/912#issuecomment-476009228, or mute the thread https://github.com/notifications/unsubscribe-auth/AADfDWU5AMCuIZW3cZNRoNWWiA3YBormks5vaAD1gaJpZM4cFmVN .