the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

Migrate to AndroidX (#911) #919

Closed bherbst closed 5 years ago

bherbst commented 5 years ago

Summary: The support libraries are now collectively part of AndroidX. This initial work uses the drop-in replacements for support library v28 (AndroidX 1.0), but there are newer versions of AndroidX packages that contain work (bugfixes, features, etc) not reflected in the support libraries.

By getting us on Android X, this PR enables us to start using the newer libraries in the future.

As much as possible, I tried to contain the changes to the minimum, but there were a few cascading issues that required me to touch more than I wanted.

The Robolectric update was interesting in that for some reason it started to throw NoClassDefFound errors on our TestTbaAndroid class. Renaming the TBAAndroid application class to match the casing of TestTbaAndroid fixed that, which caused a lot more files to change than I wanted.

The vast majority of these changes are simply replacing the old package names with the new ones, and the vast majority of those changes were done with the automatic refactoring built into Android Studio.

Highlights of meaningful changes:

Issues Reference:

911

Test Plan: Yeesh. I ran the unit tests and poked around the app for a while, but the more people using it prior to release the better.

bherbst commented 5 years ago

🤞 for Travis

bherbst commented 5 years ago

At least one flaky test is making Travis sad, but I've seen each step succeed individually 🙃

phil-lopreiato commented 5 years ago

:open_mouth:

This is awesome!