the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

Notifications don't handle playoff tiebreaker criteria properly #926

Open lethosor opened 4 years ago

lethosor commented 4 years ago

A playoff match where the overall score was tied will display "teams A-B-C tied D-E-F scoring X-X" in the notification, even in cases when the tie was broken. (Since #734, this is displayed correctly in the app when selecting the notification.)

I suspect this is the cause (but I don't have a dev environment set up to test it). The winning_alliance field from the API should be correct (example). https://github.com/the-blue-alliance/the-blue-alliance-android/blob/aa3280387d5604b233756504dedc63a4d7243d27/android/src/main/java/com/thebluealliance/androidclient/gcm/notifications/ScoreNotification.java#L125-L126