search

the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

2020 events shown as offseasons incorrectly. #930

Closed gregmarra closed 4 years ago

gregmarra commented 4 years ago

bug may be in https://github.com/the-blue-alliance/the-blue-alliance-android/blob/5c94e11e5640a08a3547c16646efec3f018835c8/android/src/main/java/com/thebluealliance/androidclient/Constants.java#L49

Events use that to calculate their ‘week’ on the client, per https://github.com/the-blue-alliance/the-blue-alliance-android/blob/5c94e11e5640a08a3547c16646efec3f018835c8/android/src/main/java/com/thebluealliance/androidclient/models/Event.java#L94

ofekashery commented 4 years ago

The issue is the event type of West Central Week 0(2020mnwcw). It should be Preseason, not Offseason.

ZachOrr commented 4 years ago

The 2020mnwcw issue specially is a server side issue - if it’s a preseason event, we need to change the event type.

Sent from my iPhone

On Dec 29, 2019, at 10:58 AM, Greg Marra notifications@github.com wrote:

 bug may be in https://github.com/the-blue-alliance/the-blue-alliance-android/blob/5c94e11e5640a08a3547c16646efec3f018835c8/android/src/main/java/com/thebluealliance/androidclient/Constants.java#L49

Events use that to calculate their ‘week’ on the client, per https://github.com/the-blue-alliance/the-blue-alliance-android/blob/5c94e11e5640a08a3547c16646efec3f018835c8/android/src/main/java/com/thebluealliance/androidclient/models/Event.java#L94

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

ZachOrr commented 4 years ago

Changing 2020mnwcw from an offseason to a preseason fixed the sorting issue.