Event codes with numbers have numbers stripped from notification titles

the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.

MIT License

76 stars 34 forks source link

Event codes with numbers have numbers stripped from notification titles #948

Open lethosor opened 4 years ago

lethosor commented 4 years ago

Example - MIKE should be MIKE2: This regex is likely the issue: https://github.com/the-blue-alliance/the-blue-alliance-android/blob/b43e02766e4d07fac3eadeed676e9a8b00ebd601/android/src/main/java/com/thebluealliance/androidclient/helpers/EventHelper.java#L37

bherbst commented 2 years ago

Unfortunately adding digits to that RegEx doesn't fix this issue due to events like https://www.thebluealliance.com/event/2022dc313

lethosor commented 2 years ago

Not sure I see the difference between 2022dc313 and 2020mike2. Is the issue you're referring to that matching digits would also pick up the year? 2020mike2 would have the same issue.

I don't think I had a particular fix in mind for this, but a couple possible variations that occur to me now are

[a-zA-Z]+[0-9]* (if we assume digits only occur at the end of the event code)
[a-zA-Z][a-zA-Z0-9]* (if digits can occur anywhere after the start of the event code)

bherbst commented 2 years ago

Ahh, I see - was looking at the wrong thing.

Now I just think DC313 is a silly event code 😆