search

the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
76 stars 34 forks source link

[Do Not Merge] Sign In With Apple #953

Open arnavs-0 opened 4 years ago

arnavs-0 commented 4 years ago

Added Initial Sign In with Apple.

Summary: Added Initial Sign In with Apple. We need to return the user for the profile. Clean up Code, Add Apple Developers to Firebase. We need to add a warning for using user data.

Test Plan: Still under development. Need to add all features. Screenshots: redirect Home redirect load

bherbst commented 4 years ago

How many Android users do we expect regularly use Apple accounts?

arnavs-0 commented 4 years ago

How many Android users do we expect regularly use Apple accounts?

I don't exactly know how much we can expect. However, I came across a couple of articles explaining why we should have it as TBA has an iOS app. It gives people who have an android device to sign in with their own apple id. More and more people are getting apple ids from Android. I am not sure how it will impact us, however, I am seeing more Sign in With Apple on Android Apps.

ZachOrr commented 4 years ago

@bherbst (it doesn’t seem like I can reply inline) re: how many Android users will use Sign In with Apple - the motivation behind this is Apple is requiring us on iOS to support Sign In with Apple, since we offer other social logins. Currently, we can’t push updates to the App Store (we’ve been blocked since April-ish) because we’re not in compliance with this new rule yet. Part of the challenge is we need to enable users to use Sign In with Apple on all of our platforms. So although signing in with an Apple ID will be rare on Android, we need it to ensure if users start their account on web with Sign In with Apple, they can pickup on Android

bherbst commented 4 years ago

Ugh, forgot about that requirement for Apple sign-in. Big old 👎 to Apple.