search

the-blue-alliance / the-blue-alliance-android

An Android app for accessing information about the FIRST Robotics Competition.
MIT License
78 stars 35 forks source link

Fix Match Key Validation for Double Elim SFs #979

Closed phil-lopreiato closed 10 months ago

phil-lopreiato commented 10 months ago

Summary: I can't believe nobody actively reported this (or that I didn't notice it in the crash logs before)...

The app's match key validation doesn't handle set numbers with two digits, so it crashes

We get this crash:

Fatal Exception: java.lang.IllegalArgumentException
Invalid match key 2023cmptx_sf11m1
com.thebluealliance.androidclient.fragments.match.MatchInfoFragment.onCreate (MatchInfoFragment.java:6)

Added some tests to cover this

Screenshots:

image